Arsenal - Fix sort by value not sorting properly #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alganthe
changed the title
|
double quote marks |
commy2
reviewed
Sep 10, 2018
|
|
||
|
|
||
| for "_i" from 0 to (((lnbsize _panel) select 0) - 1) do { | ||
| _panel lnbSetText [[_i, 2], str (parseNumber (_panel lnbText [_i, 2]) * 1000)]; |
There was a problem hiding this comment.
May need rounding? Not sure.
There was a problem hiding this comment.
no need for rounding
commy2
reviewed
Sep 10, 2018
| @@ -35,7 +35,16 @@ if (ctrlIDC _control == 17 && {GVAR(currentLeftPanel) in [IDC_buttonUniform ,IDC | |||
| }; | |||
|
|
|||
| case 2: { | |||
| for "_i" from 0 to (((lnbsize _panel) select 0) - 1) do { | |||
| _panel lnbSetText [[_i, 2], str (parseNumber (_panel lnbText [_i, 2]) / 1000)]; | |||
|
2 many parenthesis ;( |
|
I find it easier to read with parenthesis |
I have the finger above the approve and request changes buttons ;) |
PabstMirror
changed the title
PabstMirror
approved these changes
Sep 12, 2018
|
:( :) |
Grey-Soldierman
pushed a commit
to Grey-Soldierman/ACE3
that referenced
this pull request
Sep 18, 2018
* Fix sort by value not sorting properly * Change single to double quotes * Remove uneeded space
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Fix sort by value not sorting properly * Change single to double quotes * Remove uneeded space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
@bux