New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - optimize handle damage caching #6657
Conversation
Shouldn't this be actually two frames later, despite the comment saying 3? |
On a single frame, does handleDamage come before or after PFEHs are run? |
Could also use |
But execNextFrame is extremely simple. Just an if and a pushBack. I really like stacking execNextFrame if it is ~2-4 frames delay. |
If you would've used diag_log diag_frameNo in HandleDamage and this one, it would still be a difference of two frames, regardless which comes first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to function identically to old way
might be a little less overhead this way too
yay |
* optimize handle damage caching * delete some rogue code * it was 2 all along * add calls
When merged this pull request will: