Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explosives - Add ace_isEOD 3DEN attribute #7080

Merged
merged 2 commits into from Oct 13, 2019
Merged

Explosives - Add ace_isEOD 3DEN attribute #7080

merged 2 commits into from Oct 13, 2019

Conversation

mharis001
Copy link
Member

When merged this pull request will:

@mharis001 mharis001 mentioned this pull request Jun 28, 2019
Closed
@mharis001 @commy2
Apply suggestions from code review
922b31b 
Co-Authored-By: commy2 <commy-2@gmx.de>
@PabstMirror
Copy link
Contributor

would it be better to use setUnitTrait ["explosiveSpecialist", true]?

@bux
Copy link
Member

bux commented Jun 29, 2019

@PabstMirror PabstMirror changed the title Add ace_isEOD 3DEN attribute Explosives - Add ace_isEOD 3DEN attribute Jul 3, 2019
@PabstMirror PabstMirror added this to the 3.13.0 milestone Jul 3, 2019
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 3, 2019
PabstMirror
PabstMirror approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUnitTrait is probably overkill (and might have locality problems calling from 3den attribute)

@PabstMirror PabstMirror merged commit 2e5cdbd into master Oct 13, 2019
@PabstMirror PabstMirror deleted the eod-3den-attribute branch October 13, 2019 17:22
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux left review comments

@commy2 commy2 commy2 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mharis001 @PabstMirror @bux @commy2