Rearm - Fix vehicles failing rearm due to case differences #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses are too (should fix rearm bug on multiple vehicles)
mharis001
reviewed
Mar 20, 2020
|
This should fix #6928 |
Co-Authored-By: mharis001 <34453221+mharis001@users.noreply.github.com>
mharis001
approved these changes
Mar 20, 2020
jonpas
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Currently the check in getTurretMagazineAmmo compares the class used in cfgVehicles' magazines array (within the turret) to the config name in cfgMagazines (returned by magazinesAllTurrets). In some cases developers have not used the same capitalization in both of these places. Within most systems this is not a problem as config classes are not case sensitive, but in the case of getTurretMagazineAmmo it means the function fails leading to a failure of the rearm action.