Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind weather overhaul #797

Merged
merged 16 commits into from Apr 22, 2015
Merged

Wind weather overhaul #797

merged 16 commits into from Apr 22, 2015

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Apr 21, 2015

@ulteq ulteq added the kind/enhancement Release Notes: **IMPROVED:** label Apr 21, 2015
@ulteq ulteq added this to the 3.0.0 milestone Apr 21, 2015
@ulteq ulteq self-assigned this Apr 21, 2015
@jaynus
Copy link
Contributor

jaynus commented Apr 21, 2015

Are these changes randomizing wind again between two clients with those getWind changes? It looks like they are. This completely negates the whole purpose of this; which was to make sure wind speeds are synchronized between a spotter and sniper.

Are the variances small enough between clients?

@nicolasbadano
Copy link
Contributor

No, the randomization is done on the server and broadcasted, similar to the old system. It's just that client side computation is more rich (more variations), while still being synced.

@jaynus
Copy link
Contributor

jaynus commented Apr 21, 2015

Then disregard my comment, I'm good with it.

@sunrrrise
Copy link

Is it correct/by design that changing weather by Zeus or MCC is no longer possible?

@jaynus
Copy link
Contributor

jaynus commented Apr 22, 2015

Is it correct/by design that changing weather by Zeus or MCC is no longer possible?

Correct. We have not added the appropriate calls in those associated modules yet. @ulteq we need to add changing the weather parameters when changed via a module

@ulteq
Copy link
Contributor Author

ulteq commented Apr 22, 2015

Is it correct/by design that changing weather by Zeus or MCC is no longer possible?

This pull request is focused on improving the wind based on real world data.
But yes, the ACE weather module overrides some of the weather parameters.

call FUNC(getMapData);

// Randomization
GVAR(temperatureShift) = 3 - random 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity these parameters should only be inited on the server

@sunrrrise
Copy link

Do you plan to make it optional and let the mission maker decide which "source" of weather is primary (weather from editor+ACE or weather from Zeus/MCC)?

@nicolasbadano
Copy link
Contributor

Do you plan to make it optional and let the mission maker decide which "source" of weather is primary

No, there's no plans for that yet (it was the same on ACE2). Some aspects of vanilla weather is not synced properly across the network, which lead to inconsistent ballistics, etc. Maybe we could at some point allow editor moduls, API calls or Zeus Modules to modify our simulation

@ulteq
Copy link
Contributor Author

ulteq commented Apr 22, 2015

Do you plan to make it optional and let the mission maker decide which "source" of weather is primary?

I suggest you open a issue for this.

ulteq added a commit that referenced this pull request Apr 22, 2015
@ulteq ulteq merged commit 543ac7c into master Apr 22, 2015
@ulteq ulteq deleted the windWeatherOverhaul branch April 22, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants