Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laser - Adds Aircraft Point Locking; Laser Spot Tracker #8453

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Laser - Adds Aircraft Point Locking; Laser Spot Tracker #8453

merged 5 commits into from
Jul 28, 2023

Conversation

LorenLuke
Copy link
Contributor

@LorenLuke LorenLuke commented Sep 24, 2021 •
edited
Loading

Trimmed down version of #7509.

When merged this pull request will:

For all Pilot Camera-equipped Vehicles:

  • Automatically point lock one's own laser designator dot while it's on, allowing your vehicle to track buildings and such, rather than the terrain behind them.
  • Add a laser spot tracker, toggled by the interaction menu.
  • Automatically lock the pilot camera to any laser dot of matching code within a 25 degree cone, so long as the LST is enabled and the pilot camera is not locked to any target.

@LorenLuke
Copy link
Contributor Author

Requesting Review.

@jonpas jonpas added kind/feature Release Notes: **ADDED:** status/review-pending labels Nov 16, 2021
@jonpas jonpas added this to the Ongoing milestone Nov 16, 2021
@LinkIsGrim LinkIsGrim self-requested a review July 14, 2023 21:54
PabstMirror
PabstMirror reviewed Jul 26, 2023
View reviewed changes
addons/laser/XEH_postInit.sqf Outdated
GVAR(laserEmitters) set [_uuid, _args];
private _unit = _args select 0;
if (hasPilotCamera _unit) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want some kind of locality check?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local _unit should be safe enough, though this will require resetting the laser to work if locality changes.

@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.16.0 Jul 28, 2023
@LinkIsGrim LinkIsGrim merged commit 2578ead into acemod:master Jul 28, 2023
5 checks passed
@BroBeansCPG BroBeansCPG mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LorenLuke @PabstMirror @LinkIsGrim @jonpas