Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Use improved loadAbs for weight calculation #8457

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Dragging - Use improved loadAbs for weight calculation #8457

merged 3 commits into from
Jun 22, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 28, 2021 •
edited
Loading

When merged this pull request will:

  • Title.

Requires Arma 2.08 and BI fix for T160990

@BaerMitUmlaut
Copy link
Member

Is the fix scheduled for 2.08?

@BaerMitUmlaut BaerMitUmlaut added the target/next-arma Requires something in arma dev branch label Sep 29, 2021
@LinkIsGrim
Copy link
Contributor Author

Bug hasn't been acknowledged yet, but the changes to loadAbs are scheduled for 2.08 (and currently in dev branch). I expect BI'll fix it before release.

@severgun
Copy link
Contributor

It can be forgotten. It would be better if you remind to KK somehow.

@LinkIsGrim
Copy link
Contributor Author

Seems like mentioned bug was fixed.

@BaerMitUmlaut BaerMitUmlaut reopened this Dec 27, 2021
@BaerMitUmlaut
Copy link
Member

Fat fingered this, sorry.

@LinkIsGrim
Copy link
Contributor Author

I was worried for a second.

@PabstMirror PabstMirror added this to the 3.14.2 milestone Mar 8, 2022
@PabstMirror PabstMirror added kind/enhancement Release Notes: **IMPROVED:** and removed target/next-arma Requires something in arma dev branch labels Mar 8, 2022
@PabstMirror
Copy link
Contributor

loadAbs seems to double count items inside backpacks

[loadAbs player, loadAbs cursorObject, loadabs player + loadAbs cursorObject]

Start: [602,0,602]
Just toolkit in cargo: [522,80,602]
Backpack w/ Toolkit in cargo: [462,220,682]

but loaded backpacks aren't that common as cargo so I'm still fine with this

@LinkIsGrim
Copy link
Contributor Author

I'll make a ticket on BI's FT and annoy KK about that eventually.

@jonpas jonpas changed the title Dragging - use improved loadAbs for weight calculation Dragging - Use improved loadAbs for weight calculation Mar 9, 2022
@jonpas
Copy link
Member

jonpas commented May 4, 2022

Is there a ticket for loaded backpacks not counting on BI FT yet?

@LinkIsGrim
Copy link
Contributor Author

LinkIsGrim commented May 5, 2022 •
edited
Loading

Don't think so. Launchers counting the mag twice is also probably a thing that's not on there. Ended up being too busy to make any tickets.

Since fixed on BI's end.

@PabstMirror PabstMirror modified the milestones: 3.14.2, 3.15.0 May 8, 2022
@PabstMirror PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022
@LinkIsGrim LinkIsGrim merged commit 793ef7b into acemod:master Jun 22, 2023
5 checks passed
@jonpas jonpas modified the milestones: Ongoing, 3.16.0 Jun 22, 2023
@johnb432
Copy link
Contributor

https://feedback.bistudio.com/T167469
Just adding this bug report here to let people know that the doubling of the mass has been reported.

@dedmen
Copy link
Contributor

dedmen commented Jul 16, 2024 •
edited
Loading

feedback.bistudio.com/T167469

Fixed in 2.18

@johnb432 johnb432 mentioned this pull request Jul 16, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@LinkIsGrim @BaerMitUmlaut @severgun @PabstMirror @jonpas @johnb432 @dedmen