Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Block radio status effect without blocking direct voice (ACRE) #8659

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

PabstMirror
Copy link
Contributor

ref IDI-Systems/acre2#1159 (will need to wait for next acre release)

@PabstMirror PabstMirror added this to the Ongoing milestone Nov 1, 2021
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Nov 2, 2021
@PabstMirror PabstMirror changed the title Common - Block radio status effect won't block PTT voice (ACRE) WIP - Common - Block radio status effect won't block PTT voice (ACRE) Nov 8, 2021
@jonpas
Copy link
Member

jonpas commented Nov 11, 2021

Merged in ACRE2.

@jonpas jonpas changed the title WIP - Common - Block radio status effect won't block PTT voice (ACRE) Common - Block radio status effect won't block PTT voice (ACRE) Nov 11, 2021
@jonpas jonpas changed the title Common - Block radio status effect won't block PTT voice (ACRE) Common - Block radio status effect without blocking direct voice (ACRE) Nov 11, 2021
@Slatery
Copy link

Slatery commented Nov 28, 2021

would just changing the variable here not block voices for unconscious players? If the variable name is to be believed it won't stop players from talking while unconscious wouldn't it?

@LinkIsGrim
Copy link
Contributor

No. This is just the blockRadio status effect, uncon voice control is handled elsewhere (setVolume).

@jonpas jonpas modified the milestones: Ongoing, 3.14.2 Nov 28, 2021
@jonpas
Copy link
Member

jonpas commented Nov 28, 2021

Merge or wait for ACRE2 to have it in a release?

@PabstMirror
Copy link
Contributor Author

this is really subjective
I think it's worse to not be able to say anything than for a captive to be able to use the radio
but it's probably fine to wait for next acre

@Slatery
Copy link

Slatery commented Nov 28, 2021

No. This is just the blockRadio status effect, uncon voice control is handled elsewhere (setVolume).

had a play around yesterday (not realizing the ACRE change needed to go through) and ran into the issue of players being able to talk while unconscious, the setVolume function handles incoming sounds not outgoing.

[_unit, "blockRadio", "ace_unconscious", _active] call EFUNC(common,statusEffect_set);
is what's used to prevent talking, which uses this does it not? I can't find anywhere in the ACRE codebase either that handles the ACE unconscious status

@jonpas
Copy link
Member

jonpas commented Dec 2, 2021

acre_sys_core_isDisabledRadio is now in an ACRE2 dev-build, so I think we can merge this and have it ready.

@LinkIsGrim
Copy link
Contributor

No. This is just the blockRadio status effect, uncon voice control is handled elsewhere (setVolume).

had a play around yesterday (not realizing the ACRE change needed to go through) and ran into the issue of players being able to talk while unconscious, the setVolume function handles incoming sounds not outgoing.

[_unit, "blockRadio", "ace_unconscious", _active] call EFUNC(common,statusEffect_set);

is what's used to prevent talking, which uses this does it not? I can't find anywhere in the ACRE codebase either that handles the ACE unconscious status

See medical_feedback component. That's where that bit is handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants