Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adv Fatigue - Make stamina penalty for weapon raised/ready scale with weapon inertia #8669

Merged
merged 5 commits into from Jun 27, 2023

Conversation

pterolatypus
Copy link
Contributor

When merged this pull request will:

  • Title
  • Makes the penalty apply to secondary weapons too

A setup with a full-length rifle, medium-range optic and flash hider has inertia around 0.9-1 so the stamina drain will be about the same in that case.
Gives lighter weapons an extra edge in CQB, as you can move faster while keeping them at the ready.

@LinkIsGrim
Copy link
Contributor

Why not cache weapons and attachments separately instead of their combinations?

@pterolatypus
Copy link
Contributor Author

Why not cache weapons and attachments separately instead of their combinations?

I expect people to switch weapons more often than they change their attachments, so that's what I'm optimising for.
I could do both, but it means another hashmap lookup and condition block to save a getNumber which is already only reached when you switch attachments, so I thought it's probably not worth it.

@veteran29 veteran29 added this to the Ongoing milestone Nov 7, 2021
@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Nov 7, 2021
@LinkIsGrim
Copy link
Contributor

"Works on my machine"

@veteran29 veteran29 self-requested a review February 2, 2022 02:00
@pterolatypus
Copy link
Contributor Author

I'm interested in more feedback about this, atm I wonder if the scaling is a bit too much (stuff like MMGs can go up to like 2.5 inertia) so I'm considering using a fractional power, like GVAR(inertia)^0.7 or something. Could also make it a setting.

@commy2
Copy link
Contributor

commy2 commented Mar 25, 2022

Bananenprinzip

@LinkIsGrim LinkIsGrim self-requested a review June 23, 2023 14:25
@LinkIsGrim
Copy link
Contributor

I'm interested in more feedback about this, atm I wonder if the scaling is a bit too much (stuff like MMGs can go up to like 2.5 inertia) so I'm considering using a fractional power, like GVAR(inertia)^0.7 or something. Could also make it a setting.

Scaling should be fine. MMGs are hell to carry around, especially raised. Stamina consumption should reflect that.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works on my machine.

@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.16.0 Jun 27, 2023
@LinkIsGrim LinkIsGrim merged commit 4a3ad40 into acemod:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants