Cookoff - Adds heating effect to cookoff

[LorenLuke]

When merged this pull request will:

• Make tanks that cook-off actually heat up on IR.

[PabstMirror]

https://community.bistudio.com/wiki/setVehicleTIPars says local effect
so I'm not sure if this will sync correctly in mp?

[LorenLuke]

@PabstMirror

Local Effect

It seems the whole thing is called and then immediately checked for locality, so I don't suspect it'll be an issue.

https://github.com/acemod/ACE3/blob/master/addons/cookoff/XEH_postInit.sqf#L4-L9

[PabstMirror]

[LorenLuke]

I'm unsure what's going on here then, as the code states that the script shouldn't even start unless the vehicle is local. Does it still do all the smoking and flame effects otherwise?

And, if so, I know it's been said to avoid remoteExec. What about remoteExecCall or BIS_fnc_MP?

[jonpas]

No, use CBA Custom Events for any network "execution".

[pterolatypus]

the script shouldn't even start unless the vehicle is local

Do it in fnc_cookOffEffect instead

[TheCandianVendingMachine]

This sends an event across the network every 1/4 second. in fnc_cookOffEffect.sqf it would be called locally. Shove _intensity somewhere in there and move the code there

[commy2]

This raises a global event from globally executed script now I think.

[TheCandianVendingMachine]

Yeah, this should be called locally now. This function is run per client

[commy2]

What's the logic behind the math here? Refering to this part:

            ((_tiPars select 0) + (_intensity * 0.01))/1.005, 
            ((_tiPars select 1) + (_intensity * 0.004))/1.002, 
            ((_tiPars select 2) + (_intensity * 0.01))/1.005

Lots of magic hard coded numbers here.

[LorenLuke]

magic numbers

The center value is the tracks/tires, while the other two are the engine and the cannon barrel, so at the outset it stands to reason that the thing having smoke exit from it and the thing with all the ammo burning inside of it would heat up faster than the tires/treads, so that's why the first and last values are equally heated up while the second one heats up more slowly.

The second half of the numbers is so as to 1) not be immediately just set to max, 2) not have a linear increase in the values as the heating would taper off, instead having a curve as it gets closer and closer to max, and 3) the math (by always going slightly more than half the distance with fixed values) allows for it to actually hit a maximum level, rather than just only get asymptotically close.

The numbers don't correlate to any real world data other than 'I think when it's belching fire, it should at least look like it has been warmed up some' followed by 'I'm sure it'll be glowing on sensors in short order', and how I feel would best correlate to how quickly a tank would heat up by cooking off.

[veteran29]

vectorAdd will be faster than doing select three times.

Suggested change

	_obj setVehicleTIPars [
	((_tiPars select 0) + (_intensity * 0.01))/1.005,
	((_tiPars select 1) + (_intensity * 0.004))/1.002,
	((_tiPars select 2) + (_intensity * 0.01))/1.005
	];
	_obj setVehicleTIPars (_tiPars vectorAdd [
	(_intensity * 0.01) / 1.005,
	(_intensity * 0.004) / 1.002,
	(_intensity * 0.01) / 1.005
	]);

[PabstMirror]

math is different
(current + add) / 1.05
vs
current + (add/ 1.05)

[TheCandianVendingMachine]

Please add comments as to what the magic numbers indicate