Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Statemachine - Improve edge case death handling #8788

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Medical Statemachine - Improve edge case death handling #8788

merged 6 commits into from
Mar 7, 2022

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Fix Controls & Respawn UI Disabled When Dead Body is Damaged #8772.
  • Add additional onStateEntered function for unconscious state. (logging + condition checking inside statemachine component)
  • Add manual statemachine transition to dead state in setDead. (handling for forced respawn on stable unit)
  • Add additional alive check in setUnconsciousState. (dead units shouldn't change consciousness state)
  • Improve/add condition checking in other statemachine functions.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@veteran29 veteran29 added the kind/bug-fix Release Notes: **FIXED:** label Jan 25, 2022
@veteran29 veteran29 added this to the 3.14.2 milestone Jan 25, 2022
veteran29
veteran29 reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I won't approve as I would like somebody more familiar with the medical_statemachine to take a look at this.

@LinkIsGrim
Copy link
Contributor Author

Wake Baer from cryosleep?

@LinkIsGrim @PabstMirror
handle scripted death without warnings
4e7fbfd 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror merged commit 9209fed into acemod:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@BaerMitUmlaut BaerMitUmlaut Awaiting requested review from BaerMitUmlaut

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Controls & Respawn UI Disabled When Dead Body is Damaged
3 participants
@LinkIsGrim @veteran29 @PabstMirror