Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Improve addWeaponItem usage #8813

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Feb 7, 2022

When merged this pull request will:

  • Add instant param to addWeaponItem usage in arsenal so magazine is reloaded instantly. This was particularly noticeable with launchers.
  • Remove obsolete comment in reloadlaunchers that implied reloading time was still being used.
  • Change some addXWeaponItem usage to straight addWeaponItem so animations are skipped as well.

See: https://community.bistudio.com/wiki/addWeaponItem

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Feb 7, 2022
@LinkIsGrim
Copy link
Contributor Author

I guess pboProject checks really don't like me.

@LinkIsGrim LinkIsGrim changed the title Arsenal - Use instant parameter of addWeaponItem Arsenal - Improve addWeaponItem usage Feb 7, 2022
@mharis001 mharis001 added this to the 3.14.2 milestone Feb 7, 2022
@PabstMirror PabstMirror merged commit 615afee into acemod:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants