Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Add wheel patching #8835

Merged
merged 19 commits into from Jun 28, 2023
Merged

Repair - Add wheel patching #8835

merged 19 commits into from Jun 28, 2023

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:

  • Adds the ability to patch wheels

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@killerswin2
Copy link
Contributor

killerswin2 commented Mar 8, 2022

@killerswin2
Copy link
Contributor

Also you can't patch run flat tires, there are very few conditions that a run flat can be patched. The hunter MATV is run flat.

@BrettMayson
Copy link
Member Author

@killerswin2 It was intended to be a quick quality of life improvement, it could be disabled by default or someone else can add more conditions if they'd like, but the state of this PR right now is all I intended to implement

@BrettMayson BrettMayson added this to the 3.16.0 milestone Sep 13, 2022
Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please I need this feature <3

addons/repair/stringtable.xml Outdated Show resolved Hide resolved
addons/repair/stringtable.xml Outdated Show resolved Hide resolved
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
addons/repair/functions/fnc_addRepairActions.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_addRepairActions.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_canPatchRemovedWheel.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_canPatchWheel.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_canPatchWheel.sqf Show resolved Hide resolved
addons/repair/functions/fnc_doPatchWheelProgress.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_getPatchWheelTime.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_getPatchWheelTime.sqf Outdated Show resolved Hide resolved
addons/repair/initSettings.sqf Outdated Show resolved Hide resolved
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
BrettMayson and others added 2 commits February 22, 2023 10:37
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror
Copy link
Contributor

9c2c3ac - icon ok?
20230222140654_1

@BrettMayson
Copy link
Member Author

Looks good to me

@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Jun 22, 2023
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, one translation issue.

addons/repair/functions/fnc_addRepairActions.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim merged commit 10c1085 into acemod:master Jun 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants