Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastroping - Improve FRIES macro and fix UBC issues in RHS Compats #8842

Merged
merged 1 commit into from
May 10, 2022

Conversation

Dahlgren
Copy link
Member

When merged this pull request will:

  • Cleanup copypasted FRIES macro
  • Remove unused FRIES macro from SOG PF compat
  • Fix UBC issues in RHS compats due to overriden Attributes classes

TODO

  • Test in game
  • Verify UBC issues are fixed

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the Ongoing milestone Mar 11, 2022
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Mar 11, 2022
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great

@PabstMirror PabstMirror marked this pull request as ready for review May 10, 2022 01:52
@PabstMirror
Copy link
Contributor

fixes

Updating base class Attributes->, by z\ace\addons\compat_rhs_usf3\config.cpp/CfgVehicles/RHS_UH1Y_FFAR/Attributes/ (original rhsusf\addons\rhsusf_c_a2port_air\config.bin)
Updating base class Attributes->, by z\ace\addons\compat_rhs_gref3\config.cpp/CfgVehicles/rhs_uh1h_hidf_unarmed/Attributes/ (original rhsgref\addons\rhsgref_c_air\config.bin)

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.14.2 May 10, 2022
@PabstMirror PabstMirror changed the title Improve FRIES macro and fix UBC issues in RHS Compats Fastroping - Improve FRIES macro and fix UBC issues in RHS Compats May 10, 2022
@PabstMirror PabstMirror merged commit e0a3bd6 into acemod:master May 10, 2022
@Dahlgren Dahlgren deleted the bugfix/fries-cleanup-rhs-ubc branch May 10, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants