Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser - Fix seeker owner return value #8862

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

zharf
Copy link
Contributor

@zharf zharf commented Apr 5, 2022

When merged this pull request will:

  • Fixes an issue with laser seeker return value mentioned here
  • Chooses the owner with most hits instead of the last one in the hashmap iteration order

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Apr 5, 2022
@PabstMirror PabstMirror added this to the 3.14.2 milestone Apr 6, 2022
@PabstMirror
Copy link
Contributor

PabstMirror commented Apr 6, 2022

Good fix,
I am curious what you're using this for.

IIRC long ago missile guidance was originally going to hand-off guidance to the laser owner
but as far as I can tell nothing in ace uses the owner value

@PabstMirror PabstMirror merged commit 72774c9 into acemod:master Apr 6, 2022
@zharf
Copy link
Contributor Author

zharf commented Apr 6, 2022

I also found that nothing used it in ACE however I traced an issue in ITC AIR to this issue
https://github.com/YannikH/itc_air/blob/master/itc_air_tgp/functions/lss/search.sqf

Not sure if they should be using this either but ITC seems to be abandoned nowadays

@zharf zharf deleted the fix-laser-seeker-final-owner branch April 7, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants