Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookoff - Improve destroying vehicle post cookoff #9029

Merged
merged 3 commits into from Jun 25, 2023

Conversation

Cyruz143
Copy link
Contributor

@Cyruz143 Cyruz143 commented Sep 13, 2022

When merged this pull request will:

  • When cookoff completes vehicles explode (depending on settings)

In it's currently implementation, when cookoff completes and you have destroyVehicleAfterCookoff enabled, there is a chance (based around _detonateAfterCookoff) that the vehicle will just change to the wreck model without an explosion. This looks a bit weird to be honest, the explosion hides the model change fairly well and looks a bit more natural.

If you have destroyVehicleAfterCookoff disabled and _detonateAfterCookoff is also false, this statement never runs so it shouldn't have any unwanted impact.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@veteran29 veteran29 added this to the 3.16.0 milestone Sep 13, 2022
@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Sep 13, 2022
@LinkIsGrim LinkIsGrim merged commit aa21ba5 into acemod:master Jun 25, 2023
5 checks passed
@Cyruz143 Cyruz143 deleted the cookoff-explosion-on-kill branch October 1, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants