Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Improve weapon reselect behaviour #9052

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Dragging - Improve weapon reselect behaviour #9052

merged 2 commits into from
Feb 14, 2023

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Improve weapon reselect behaviour when dropping carried objects
  • Previously, this would always reselect the primary weapon but now reselects whatever weapon (or none) was held when carrying was started

@mharis001 mharis001 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 1, 2022
@mharis001 mharis001 added this to the 3.16.0 milestone Oct 1, 2022
jonpas
jonpas reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why public setVariable?

@mharis001
Copy link
Member Author

Public variable isn't specifically required but should allow for handling disconnecting players better.

@Dystopian Dystopian mentioned this pull request Oct 20, 2022
Closed
@PabstMirror PabstMirror merged commit 67ebb15 into master Feb 14, 2023
@PabstMirror PabstMirror deleted the dragging-weapon-select branch February 14, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 left review comments

@jonpas jonpas jonpas left review comments

@veteran29 veteran29 veteran29 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mharis001 @veteran29 @commy2 @jonpas @PabstMirror