Arsenal - Add init/remove local events to Arsenal creation/destruction #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* onInitArsenal fired when Arsenal got initiated * onRemoveArsenal fired when Arsenal got removed * added them to the arsenal event listing in the docs
BrettMayson
requested changes
Oct 6, 2022
Co-authored-by: BrettMayson <brett@mayson.io>
Co-authored-by: BrettMayson <brett@mayson.io>
BrettMayson
requested changes
Oct 6, 2022
Co-authored-by: BrettMayson <brett@mayson.io>
BrettMayson
approved these changes
Oct 6, 2022
PabstMirror
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add "ace_arsenal_boxInitialized" local event on the creation of an arsenal box via fnc_initBox
Add "ace_arsenal_boxRemoved" local event on the removal of an arsenal box via fnc_removeBox
Events are added to arsenal event list in docs
Why?: My mod adds sub actions to the arsenal interaction menu tree. Currently there is no way to cleanly hook into that process and add these extensions every time an arsenal is created. There is an event "initBox" that gets fired only in multiplayer and for global arsenals that works in certain cases, but feels like an abuse of an internal version.
I see no point of rewriting that event, as it clearly serves a specific purpose, not a gneralized one.
A generalized local event to enable reactions to arsenals being initiated or removed is the better solution and almost free.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.