Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Hide cursor during progress bar #9128

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Common - Hide cursor during progress bar #9128

merged 3 commits into from
Jan 24, 2023

Conversation

JonBons
Copy link
Contributor

@JonBons JonBons commented Jan 23, 2023 •
edited
Loading

When merged this pull request will:

  • Hides the cursor while the progress bar dialog is drawn.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 23, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Jan 23, 2023
@PabstMirror
Copy link
Contributor

Might not even need the settings

@mharis001
Copy link
Member

I don't think the setting adds value and the default is the better behaviour.

@JonBons
Copy link
Contributor Author

JonBons commented Jan 23, 2023

Yeeted.

@JonBons JonBons changed the title Common - Hide cursor during progress bar (w/ CBA setting) Common - Hide cursor during progress bar Jan 23, 2023
mharis001
mharis001 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@PabstMirror PabstMirror merged commit 6b3aa3e into acemod:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonBons @PabstMirror @mharis001