Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Fixed CBA keybinds not working with progress bar #9139

Merged
merged 2 commits into from Feb 14, 2023

Conversation

JonBons
Copy link
Contributor

@JonBons JonBons commented Jan 29, 2023

When merged this pull request will:

  • Due to the way the map control works we have to manually call into CBA to hook eventhandlers onto the display to work

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@PabstMirror PabstMirror modified the milestone: 3.16.0 Jan 31, 2023
@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** labels Jan 31, 2023
@PabstMirror
Copy link
Contributor

on current master (without this PR) I tested the following code and it worked as expected when running a progressbar


["testt", "test", "test", {
    systemChat format ["%1 - Down", time];
},
{
    systemChat format ["%1 - Up", time];
}, [47, [false, false, false]], false] call CBA_fnc_addKeybind; // v

So I'm not sure if this is needed?

@JonBons
Copy link
Contributor Author

JonBons commented Feb 3, 2023

@PabstMirror It only breaks with CBA binds on the numpad that are also used to move the map around in vanilla arma (Num 2/4/6/8, etc) due to the fact the cursor hack uses a map dialog.

@PabstMirror
Copy link
Contributor

confirmed needed for those keys
and cba_events should be able to handle the doubled events for normal keys

@PabstMirror PabstMirror merged commit 86d79b2 into acemod:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants