Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortify - Categories #9167

Merged
merged 8 commits into from Mar 19, 2023
Merged

Fortify - Categories #9167

merged 8 commits into from Mar 19, 2023

Conversation

PabstMirror
Copy link
Contributor

Close #9097

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 8, 2023
class TAG_categories{
displayName = "Combo";
presets[] = {"big", "bigGreen"}; // will load presets big and bigGreen each under their own sub category
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not exactly clear to me how it should be used.

Should TAG_MyPreset be added to TAG_categories presets[] array and should the #ace-fortify blufor TAG_categories command be ran?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added note that presets can be from configFile as well, which is where big comes from
I can add a fuller example if we think that would help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fuller/additonal example would be better, also can objects be mixed with presets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah they can be mixed in, they'll just be at top level along the sub-categories
I thought presets[] was a neat way to organize
but if it's recursion is confusing to users we can just as easily change to something like

class ACEX_Fortify_Presets {
    class TAG_MyPreset2 {
        displayName = "My Preset";
        objects[] = {
            {"Sandbag", 5, "categoryA"},
            {"Bunker", 50, "categoryB"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class ACEX_Fortify_Presets {
class TAG_MyPreset2 {
displayName = "My Preset";
objects[] = {
{"Sandbag", 5, "categoryA"},
{"Bunker", 50, "categoryB"}

First and foremost, thank you for your efforts. This, I believe, is the best way to add new categories with the descriptions. ext , when do you think this will be available? 

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
docs/wiki/framework/fortify-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/fortify-framework.md Outdated Show resolved Hide resolved
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror PabstMirror added this to the 3.16.0 milestone Mar 11, 2023
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror PabstMirror merged commit bcbd762 into master Mar 19, 2023
@PabstMirror PabstMirror deleted the fortifyCategories branch March 19, 2023 00:23
@jonpas jonpas added kind/feature Release Notes: **ADDED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortify categories
5 participants