Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - switch ace's getTurretConfigPath to use CBA_fnc_getTurret #9180

Merged
merged 1 commit into from Apr 14, 2023

Conversation

PabstMirror
Copy link
Contributor

cwr british fv4030

class Turrets: Turrets {  
  particlesPos = "usti hlavne"; 
  particlesDir = "konec hlavne"; 
  class CommanderOptics: CommanderOptics {

["cwr3_b_uk_fv4030", [0,0]] call BIS_fnc_turretConfig
returns bin\config.bin/CfgVehicles/cwr3_challenger1_base/Turrets/MainTurret/Turrets/particlesPos
should be bin\config.bin/CfgVehicles/cwr3_challenger1_base/Turrets/MainTurret/Turrets/CommanderOptics

BIS_fnc_turretConfig and ace_common_fnc_getTurretConfigPath both parse it wrong and ends up causing

Warning Message: 'particlesDir/' is not a class ('ace_fcs_Enabled' accessed)

I think the config is bad but CBA_fnc_getTurret handles it right
and is slightly faster (0.018 vs 0.012) so I don't see any reason not to switch over

ref https://github.com/CBATeam/CBA_A3/blob/master/addons/common/fnc_getTurret.sqf

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Apr 3, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Apr 3, 2023
@commy2
Copy link
Contributor

commy2 commented Apr 3, 2023

2016 commy: 1 -- 2014 commy: 0 -- BI: -1000

@PabstMirror PabstMirror merged commit b78f868 into master Apr 14, 2023
5 checks passed
@PabstMirror PabstMirror deleted the getTurretCBA branch April 14, 2023 22:43
@PabstMirror PabstMirror changed the title Common - switch getTurretConfigPath to use cba func Common - switch ace's getTurretConfigPath to use CBA_fnc_getTurret Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants