Vehicle Damage - Fix blank hit selections resulting in absurd damage to the driver #9194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Repro steps
Using
CUP_B_BMP2_CZ
for testing, some observations:I iterated on all kinds of different damage combinations and eventually discovered what seems to be one cause (I'm sure the logic means it applies in other ways as well):
It may not happen on the first bush you go through, but it'll happen soon enough. It's probably just dependent on whatever you hit managing to hit one of those obliterated lights to trigger it.
Go into a mission, create the BMP with the following snippet
Damage the lights (this only damages some of the selections, the others need to be damaged by driving into a building)
Now drive into a building a few times to damage the other selections, after doing so drive over a bush or crash through a small wall and watch as the driver recieves a bunch of wounds.
If you need to repair the vehicle after slamming into a building too many times (resulting in disabled tracks/engine)
Here is a video of repro showing toggling the fix on/off: https://youtu.be/KNprZ4aezRY