New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Add "ace_explosives_setup" CBA Event #9197
Conversation
I have added back the |
@BrettMayson The event "ace_explosives_place" is undocumented, would you prefer I left this out of documentation or created a section for the two events (ace_explosives_place and ace_explosives_setup) in the explosives framework documentation |
I would document |
Title of this PR should be something like |
|
@LinkIsGrim Could you be more specific? Both the descriptions (You didn't mention it, but I also noticed it was wrong) and naming was fixed, if there's another issue, I can't see i t |
When merged this pull request will:
Currently, the "ace_explosives_place" event only triggers when a "trigger" is added to the explosive. This adds an event that passes in the placed explosive's vehicle, the mag class and the unit that placed the explosive.
Personally, the current event should be renamed and this one should be named "place" however, to avoid fallout with other mods that depend on this one, I've simply created a new one to keep the two separate and not cause other mods to need to be updated.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.