Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Fix bug in detection for ignoring hitpoints #9261

Merged
merged 5 commits into from Jul 28, 2023

Conversation

tbeswick96
Copy link
Contributor

When merged this pull request will:

  • Fix bug in detection for ignoring repair hitpoints

@tbeswick96 tbeswick96 changed the title Repair - Fix bug in detection for ignoring repair hitpoints Repair - Fix bug in detection for ignoring hitpoints Jul 13, 2023
@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Jul 15, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Jul 15, 2023
@PabstMirror
Copy link
Contributor

my changes to this could use another eyes

TRACE: 6396 Skipping child hitpoint: _hitpoint=hitengine1, _forEachIndex=2, _selection=engine_1_hit z\ace\addons\repair\functions\fnc_getHitPointsToIgnore.sqf:134
TRACE: 6396 Skipping child hitpoint: _hitpoint=hitengine2, _forEachIndex=3, _selection=engine_2_hit z\ace\addons\repair\functions\fnc_getHitPointsToIgnore.sqf:134
TRACE: 6396 Skipping depends hitpoint: _hitpoint=hitengine, _forEachIndex=4, _selection=engine_hit z\ace\addons\repair\functions\fnc_getHitPointsToIgnore.sqf:117
ERROR: [O_Heli_Transport_04_F] hitpoint [hitengine] is both a group-parent and a depends and will be unrepairable
ERROR: group: ["HitEngine",["HitEngine1","HitEngine2"]]

there was another bug with this, the entire hitpoint group became unrepairable because
we ignored the children
but the parent was also a "depends" hitpoint and was also ignored

I think the reason for groups was long before the depends system and may not be needed anymore
this removes the one use of hitpointGroups config, I'm not sure of other addons usage but we can keep an eye out

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break anything?

addons/repair/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/repair/CfgVehicles.hpp Outdated Show resolved Hide resolved
@tbeswick96
Copy link
Contributor Author

tbeswick96 commented Jul 20, 2023

Bad merge, will repair

Sautéd

@tbeswick96 tbeswick96 force-pushed the fix/ignore-hitpoint-detection branch from f467c9a to ba65ea1 Compare July 20, 2023 17:41
@tbeswick96 tbeswick96 force-pushed the fix/ignore-hitpoint-detection branch from ba65ea1 to b1a7496 Compare July 20, 2023 17:42
@veteran29 veteran29 self-requested a review July 21, 2023 15:32
@LinkIsGrim LinkIsGrim merged commit cd36871 into acemod:master Jul 28, 2023
5 checks passed
@tbeswick96 tbeswick96 deleted the fix/ignore-hitpoint-detection branch July 28, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants