Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Make Zeuses able to save, delete, and edit Default Loadouts #9278

Merged
merged 2 commits into from Jul 28, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Jul 21, 2023

When merged this pull request will:

  • Title.
  • Add global parameter to FUNC(addDefaultLoadout).
  • Switch to using FUNC(addDefaultLoadout) internally.
  • Add FUNC(removeDefaultLoadout) and FUNC(renameDefaultLoadout). What it says on the tin.
  • Add documentation for above.

Loadout index in the local loadout save events remains the same, but that whole behavior's weird with default loadouts.
Loadout save/delete events aren't fired remotely in MP.
Doesn't have the same handling as public loadouts. Should it? I don't think there's much issue with the list not being updated until the player changes tabs. Default loadouts shouldn't be getting updated that often.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Jul 21, 2023
@LinkIsGrim
Copy link
Contributor Author

Tested in SP and Eden, no idea if MP'll work (it should?).

Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in local mp

@PabstMirror PabstMirror added this to the 3.16.0 milestone Jul 28, 2023
@LinkIsGrim LinkIsGrim merged commit 5e6476a into acemod:master Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants