Medical Status - Remove status effects upon death/featureCamera

[johnb432]

When merged this pull request will:

• If a unit was unconscious and then died, they would have the setHidden, blockRadio and blockSpeaking status effects still applied. The first is not important, but the two others are, especially blockSpeaking, which (I believe) prevented spectators talking in the spectator view when using TFAR.

This PR reverses those status effects upon death.
Unsure if ACRE is affected in any negative way.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[LinkIsGrim]

IMO status effect setting/unsetting should be moved to a function, this will absolutely get confusing in the future.

[johnb432]

IMO status effect setting/unsetting should be moved to a function, this will absolutely get confusing in the future.

Any suggestions?

[LinkIsGrim]

LinkIsGrim/ACE3@2feacbb, I'm just not sure on skipSetHidden there.

[johnb432]

LinkIsGrim/ACE3@2feacbb, I'm just not sure on skipSetHidden there.

I don't think it's necessary, went ahead and removed it.

[LinkIsGrim]

That being the case, the uncon unit will become a valid target for AI upon opening a camera. I don't particularly like that idea due to some communities using spectator for downed players.

[PabstMirror]

imho this is an TFAR problem
all we do is set

_object setVariable ["tf_voiceVolume", [1, 0] select (_set > 0), true];
_object setVariable ["acre_sys_core_isDisabledRadio", _set > 0, true];

if the unit is dead or otherwise spectating that shouldn't matter
made a PR michail-nikolaev/task-force-arma-3-radio#1562 that I think should fix on their end?

[LinkIsGrim]

imho this is an TFAR problem all we do is set

_object setVariable ["tf_voiceVolume", [1, 0] select (_set > 0), true];
_object setVariable ["acre_sys_core_isDisabledRadio", _set > 0, true];

if the unit is dead or otherwise spectating that shouldn't matter made a PR michail-nikolaev/task-force-arma-3-radio#1562 that I think should fix on their end?

Poke if that gets merged, this should be unnecessary then.

[jonpas]

Close?

[johnb432]

Close?

I feel it's poor design on TFAR's part, but I don't quite agree it's their fault.

The PR made to address it on TFAR's end hasn't been merged, so I feel it might be safer to keep this PR open until it's addressed.

[jonpas]

It probably will never get merged, and if it will, it'll never get released. @dedmen ?

Does this PR address any other possible issue?

[johnb432]

Does this PR address any other possible issue?

Unfortunately it doesn't, as I don't have the necessary information to reproduce the errors. It only handles death of uncon units causing them to be muted as spectators.

[jonpas]

It seems like a general bad-state safety improvement to me though, so merge anyways?

[jonpas]

That being the case, the uncon unit will become a valid target for AI upon opening a camera. I don't particularly like that idea due to some communities using spectator for downed players.

Actually, if that happens, this PR is a no-go.

[johnb432]

Actually, if that happens, this PR is a no-go.

What if I were to revert the changes made in d647710?

The script would only execute upon death then.

[jonpas]

Somebody else will have to comment on the rest of the changes.

[dedmen]

It probably will never get merged, and if it will, it'll never get released. @dedmen ?

Why not? Probably weeks/months but not never

[jonpas]

As a "beta". :P

[johnb432]

Somebody else will have to comment on the rest of the changes.

I reverted the problematic changes, should be good to be reviewed.

[jonpas]

That being the case, the uncon unit will become a valid target for AI upon opening a camera. I don't particularly like that idea due to some communities using spectator for downed players.

@LinkIsGrim re-review please.

[PabstMirror]

michail-nikolaev/task-force-arma-3-radio#1562 was merged

[LinkIsGrim]

Will TFAR be updated any time soon?

[PabstMirror]

https://steamcommunity.com/sharedfiles/filedetails/?id=894678801 had an update Jun 14
but i'm not opposed to this PR in it's current state
has anyone tested if AI start shooting bodies when they go from uncon to death? I doubt they would

[LinkIsGrim]

From SP testing, they don't. AFAIK dead bodies aren't valid targets for the AI brain.