Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical GUI - Dynamically create any number of action buttons #9332

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Medical GUI - Dynamically create any number of action buttons #9332

merged 2 commits into from
Aug 25, 2023

Conversation

PabstMirror
Copy link
Contributor

maybe alternate to #9325
20230817224039_1

@SpicyBagpipes
Copy link
Contributor

SpicyBagpipes commented Aug 18, 2023 •
edited
Loading

Imo this is the better option between this and pagination, would just have the padding between buttons still and make scroll bar edge not overlap triage edge
image

@jonpas jonpas changed the title Medical Gui - Dynamically create any number of action buttons Medical GUI - Dynamically create any number of action buttons Aug 18, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Aug 19, 2023
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 19, 2023
@PabstMirror
Copy link
Contributor Author

20230818193707_1

kymckay
kymckay approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, love a PR that reduces lines of config!

@SpicyBagpipes
Copy link
Contributor

Looks good now, should I close my PR?

@PabstMirror PabstMirror merged commit 65d5ccf into master Aug 25, 2023
5 checks passed
@PabstMirror PabstMirror deleted the medGuiDynamicButtons branch August 25, 2023 15:32
@SpicyBagpipes SpicyBagpipes mentioned this pull request Aug 25, 2023
Closed
3 tasks
@Nilia119 Nilia119 mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kymckay kymckay kymckay approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PabstMirror @SpicyBagpipes @kymckay @LinkIsGrim