New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captives - Add modded cable tie support #9350
Conversation
…e-support Captives - Add modded cable tie support
need to update ACE_captives_fnc_doApplyHandcuffs as well |
Just want first instance of kind of ace_cabletie or child found removed? |
Why not go with the approach found here? |
Don't see any benefit to it in this instance as no backpacks etc for entrenching tools and anyone who has already tried to create their own likely inherits from cable tie |
Reasonable. The only benefit I see in adding a function is for public usage, but I'm not sure how needed such a function would be. |
I propose making it an attribute. I don't like using inheritance for this. ace_captives_is_cable_tie = 1; |
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
I think |
As is not exposed to end users I think |
Though not opposed to adding a rope restraint or something to expand on it? 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute is currently not set on the default cable ties.
Can do this for all the other "tools" currently present (think it's just the defusal kit left with no modded support) if desired, changes only add .0012ms to the condition. Makes no sense to leave the defusal kit out if all the rest have modded support imo |
Right, I'm saying it should be different than the item name because if I add a handcuff item in the future it will be odd to call it a cable tie. |
Done |
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.