Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers - Don't try to move poly-line markers #9381

Merged
merged 1 commit into from Sep 9, 2023
Merged

Conversation

PabstMirror
Copy link
Contributor

Close #9380

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 9, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Sep 9, 2023
Copy link
Contributor

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No half-measures.

@@ -17,6 +17,8 @@

params [["_marker",""]];

if ((markerShape _marker) == "POLYLINE") exitWith { false };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((markerShape _marker) == "POLYLINE") exitWith { false };
if ((markerShape _marker) isEqualTo "POLYLINE") exitWith { false };

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Look at markerShape return values.

@PabstMirror PabstMirror merged commit 29ba42b into master Sep 9, 2023
5 checks passed
@PabstMirror PabstMirror deleted the markerpoly branch September 9, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers - Look at Marker syncing
4 participants