Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal/Compat RHS - Improve support for RHS attachments #9386

Merged
merged 12 commits into from Sep 25, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 11, 2023

When merged this pull request will:

  • Add event ace_arsenal_weaponItemChanged: params _weapon, _item, _itemIndex. _itemIndex is relative to ace_arsenal_currentItems attachment array. Documented. Fires on weapon attachment/magazine change.
  • Use above event to call RHS's function for optic/attachment switching.
  • Add baseWeapon property to RHS rail attachments.
  • Add handling in ace_arsenal_fnc_scanConfig for RHS scripted optics. Overrides baseWeapon cache.

Partial address of #9384.

Prevents this:
107410_20230919071921_1

And this:
107410_20230919072010_1

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Sep 11, 2023
@LinkIsGrim LinkIsGrim marked this pull request as ready for review September 11, 2023 00:44
@PabstMirror PabstMirror self-requested a review September 23, 2023 17:43
addons/compat_rhs_usf3/XEH_postInit.sqf Outdated Show resolved Hide resolved
@PabstMirror PabstMirror added this to the 3.16.0 milestone Sep 23, 2023
@jonpas jonpas merged commit ac29287 into acemod:master Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants