Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus - Fix Group Side module #9388

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Fixes following issue that was found:
20:23:46 Error in expression <dTeam _x;
[_x] joinSilent _newGroup;
_x assignTeam _team;
} forEach units _unit;>
20:23:46   Error position: <assignTeam _team;
} forEach units _unit;>
20:23:46   Error Foreign error: Unknown enum value: ""
20:23:46 File /z/ace/addons/zeus/functions/fnc_moduleGroupSide.sqf..., line 343
  • If assignedTeam returns "", the default team is "MAIN".

I'm convinced that prior to 2.14 this was not an issue. I think there were some related changes, but I can't remember for sure.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@jonpas
Copy link
Member

jonpas commented Sep 11, 2023

1.94
"" if given unit is objNull or remoteControlling another unit

Still shouldn't cause that though.

@jonpas jonpas changed the title Zeus - Fixed Group Side module Zeus - Fix Group Side module Sep 11, 2023
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Sep 11, 2023
@jonpas jonpas added this to the 3.16.0 milestone Sep 11, 2023
@johnb432
Copy link
Contributor Author

Still shouldn't cause that though.

I agree, it's odd, but I think for a split second when a unit is removed from the group the team information gets lost. That's the only explanation I have, as the AI was not remote controlled and not null.

Test setup was as follows: Player was group leader, one AI as subordinate. Test was in SP.

Co-authored-by: jonpas <jonpas33@gmail.com>
@jonpas jonpas merged commit 119702a into acemod:master Sep 12, 2023
5 checks passed
@johnb432 johnb432 deleted the change-sides-zeus-module-fix branch January 14, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants