Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add lockInventory status effect #9402

Merged
merged 1 commit into from Sep 22, 2023

Conversation

JasperRab
Copy link
Contributor

When merged this pull request will:
Adds lockInventory status effect, for cross-mod compatibility possibilities.
Tested both in singleplayer and multiplayer settings.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

self note, we could probably use this to replace ACE_VehicleLock_fnc_onOpenInventory which is old/clunky

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Sep 17, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Sep 17, 2023
@JasperRab
Copy link
Contributor Author

JasperRab commented Sep 18, 2023

The only thing I was still thinking about adding is that it would "kick" players out of the inventory screen when it's being locked. That currently doesn't happen by vanilla.
However not sure if it's better to do that in a separate PR.

@LinkIsGrim LinkIsGrim merged commit 6f58830 into acemod:master Sep 22, 2023
5 checks passed
@JasperRab
Copy link
Contributor Author

JasperRab commented Sep 23, 2023

Found an issue with this, for JIP players, it won't be locked.
idk if the status effect stuff actually supports JIP stuff?

The setVariable is there on the object. But the code from the CBA event doesn't obviously run.

Maybe we have to change the CBA_fnc_globalEvent in fnc_statusEffect_sendEffects to a CBA_fnc_globalEventJIP?
Idk what this would do though with existing effects... Add a JIP flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants