Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Treatment: Add graves event and setting for markers #9441

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

BrettMayson
Copy link
Member

@BrettMayson BrettMayson commented Sep 28, 2023

When merged this pull request will:

  • Adds Create Grave Markers setting
  • Adds ace_placedInGrave that fires regardless of marker creation
  • ace_placedInBodybag will not fire if marker creation is disabled

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if grave "markers" is a good name: I had to look to see if you weren't referring to map markers.

Code looks good.

@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Sep 28, 2023
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Sep 28, 2023
@LinkIsGrim LinkIsGrim merged commit 66deb59 into acemod:master Oct 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants