Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical GUI - Add outline to selected body part in Medical Menu #9471

Merged
merged 11 commits into from Oct 11, 2023
Merged

Medical GUI - Add outline to selected body part in Medical Menu #9471

merged 11 commits into from Oct 11, 2023

Conversation

amsteadrayle
Copy link
Contributor

When merged this pull request will:

  • Indicate the selected body part in the body image display

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@amsteadrayle
Copy link
Contributor Author

Demo video:
https://www.youtube.com/watch?v=Az0f1CMXNuY

The red overlay is just temporary for demo and testing. New textures need to be made, but the functionality should be complete.

From my comment in the feature request issue:

Add an outline to the currently selected body part. This makes it abundantly clear which body part you have selected, and also adds feedback when clicking a body part to indicate that you have selected that body part.

@amsteadrayle
Copy link
Contributor Author

First pass at body part outlines:

showselectedpart_2.mp4

@amsteadrayle
Copy link
Contributor Author

showselectedpart_4.mp4

@amsteadrayle amsteadrayle changed the title WIP - Medical GUI - Show selected body part on body image Medical GUI - Show selected body part on body image Oct 9, 2023
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Oct 9, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Oct 9, 2023
@amsteadrayle @LinkIsGrim
Fix capitalization
a33fc43 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
LinkIsGrim requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix merge conflicts

addons/medical_gui/initSettings.sqf Outdated Show resolved Hide resolved
addons/medical_gui/stringtable.xml Outdated Show resolved Hide resolved
amsteadrayle and others added 2 commits October 10, 2023 20:08
@amsteadrayle @LinkIsGrim
Fix capitalization
1f3c0fb 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@amsteadrayle
Merge branch 'master' into showSelectedBodypart
b9cdcca
@amsteadrayle amsteadrayle mentioned this pull request Oct 11, 2023
Merged
3 tasks
@LinkIsGrim LinkIsGrim modified the milestones: 3.16.1, 3.16.0 Oct 11, 2023
@LinkIsGrim LinkIsGrim changed the title Medical GUI - Show selected body part on body image Medical GUI - Add outline to selected body part in Medical Menu Oct 11, 2023
@LinkIsGrim LinkIsGrim merged commit 008cd5a into acemod:master Oct 11, 2023
5 checks passed
@SGTdanny50567 SGTdanny50567 mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amsteadrayle @PabstMirror @LinkIsGrim