New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common - Add support for non-blocking progress bar #9493
Common - Add support for non-blocking progress bar #9493
Conversation
Is there a reason that the progress bar intercepts mouse movement? Not being able to freelook while in progress has been a little pet peeve of mine for a long time. |
The progress bar is a UI dialog. Dialogs and displays intercept mouse movement. That's about it. |
I can't find a way to avoid the fade-in, "PLAIN NOFADE" has no effect on cutRsc. Didn't edit the function header. I'm lazy. Interactions with animations will still block player movement even with the new param. Freelook is unaffected. Interactions without animations will allow player movement/vehicle control freely. Anyone using this will need to embed that in condition. Again, this has to be used explicitly. Default behavior is the dialog. This PR only modifies airdropping to use this. |
How well does it handle death?
You should add it. I really don't like the fading in, but I don't know how to fix it. Considering it's used in 1 instance only, I think we can, at least for now, ignore that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gonna edit the header. Hold on merge till then. |
Should be same as the regular progress bar handles it, but haven't tested for that specifically. |
Note for changelog, add note on airdrop change. |
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Removing the key handler twice doesn't cause any issues, thankfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed during testing that pressing the "Airdrop" button would sometimes fail silently. I can't get a proper repro though,
I assume this will be merged before #9617, which will give us more time to determine what the issue is.
Likely failed due to flight conditions, notification should pop up though. |
When merged this pull request will:
This does not replace the current progress bar functionality (dialog).
Pressing Escape/opening a dialog/opening the interaction menu still closes the progress bar. Is there anything else that needs to be handled by this?
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.