Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Add stat for capabilities of pointer attachments #9499

Merged
merged 3 commits into from Oct 21, 2023
Merged

Arsenal - Add stat for capabilities of pointer attachments #9499

merged 3 commits into from Oct 21, 2023

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Oct 16, 2023 •
edited

image

@PabstMirror PabstMirror changed the title Arsenal - Add stat for illuminator//pointer attachments Arsenal - Add stat for capabilities of pointer attachments Oct 20, 2023
@PabstMirror PabstMirror marked this pull request as ready for review October 20, 2023 01:17
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 20, 2023
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Oct 20, 2023 •
edited

Gonna be honest, I don't understand what the suffixes mean.

EDIT: Looked at comment. Obtuse IMO.

@PabstMirror
Copy link
Contributor Author

maybe going to 3 chars will help, but then some with many modes will get cut off

@LinkIsGrim
Copy link
Contributor

We can always make the stat window larger

@PabstMirror
Copy link
Contributor Author

For most attachment it works just fine
On the few it doesn't you still know it has a lot of modes
image

@LinkIsGrim LinkIsGrim merged commit dd0838b into master Oct 21, 2023
4 checks passed
@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Oct 21, 2023
@jonpas jonpas deleted the arsenalPointerStat branch October 21, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PabstMirror @LinkIsGrim