Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night Vision - Add prefix to colorPreset #9520

Merged
merged 2 commits into from Oct 18, 2023
Merged

Night Vision - Add prefix to colorPreset #9520

merged 2 commits into from Oct 18, 2023

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Oct 18, 2023

When merged this pull request will:

  • Prefixes colorPreset
  • Adds BWC for "colorPreset"
  • Update framework wiki page because the standard doesn't seem to be GVAR(x)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Oct 18, 2023

Prefix is fine, I don't get how you implemented BWC on this though.

@LinkIsGrim LinkIsGrim added the kind/cleanup Release Notes: **CHANGED:** label Oct 18, 2023
@SpicyBagpipes
Copy link
Contributor

SpicyBagpipes commented Oct 18, 2023

Prefix is fine, I don't get how you implemented BWC on this though.

private _preset = getArray (configFile >> "CfgWeapons" >> "NVGoggles" >> QGVAR(colorPreset));

// BWC for ACE prefix on colorPreset.
if (_preset isEqualTo []) then {
    _preset = getArray (configFile >> "CfgWeapons" >> "NVGoggles" >> "colorPreset");
};

getarray will return [] if no value found

@LinkIsGrim
Copy link
Contributor

Yes, but HMD/binoc doesn't have the same handling.

Honestly if we hotfix with just the prefix change it should be fine though.

@Mike-MF
Copy link
Member Author

Mike-MF commented Oct 18, 2023

the BWC i did doesn't even matter.

"NVGoggles" is set by ACE, so it would never have the old `"colorPreset".

I just didn't notice it.

@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Oct 18, 2023
@LinkIsGrim LinkIsGrim changed the title Night Vision - Prefix colorPreset Night Vision - Add prefix to colorPreset Oct 18, 2023
@LinkIsGrim LinkIsGrim merged commit 262b7fe into master Oct 18, 2023
4 checks passed
@jonpas jonpas deleted the nvg-prefix branch October 18, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants