Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Fix saving loadouts on new profiles #9523

Merged
merged 3 commits into from Oct 18, 2023
Merged

Arsenal - Fix saving loadouts on new profiles #9523

merged 3 commits into from Oct 18, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Oct 18, 2023 •
edited

When merged this pull request will:

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Oct 18, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Oct 18, 2023
@PabstMirror
Copy link
Contributor

PabstMirror commented Oct 18, 2023 •
edited

Close #9522 I think

not sure why this is needed, seems like all use of
profileNamespace getVariable [QGVAR(saved_loadouts),[]]
is the array form (with default value)
edit: I get it it, it works because the array ref, it's never explicitly saved

@LinkIsGrim LinkIsGrim merged commit b2b49cc into acemod:master Oct 18, 2023
4 checks passed
@PabstMirror PabstMirror mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

Arsenal - Saving loadouts breaks on new profiles
3 participants
@LinkIsGrim @PabstMirror @BrettMayson