Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Engine - Disable uniform passthrough scaling, increase passthrough effect on vests #9524

Merged
merged 4 commits into from Oct 24, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Oct 18, 2023

When merged this pull request will:

  • Title.

I forgot to take uniform hitpoint armor being multiplied by unit overall armor into account when adding up everything. This should also make stacking armored uniforms with vests less broken.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Oct 18, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Oct 18, 2023
@LinkIsGrim LinkIsGrim changed the title Medical Engine - Increase passthrough scaling for vests Medical Engine - Increase passthrough effect for vests Oct 18, 2023
@LinkIsGrim
Copy link
Contributor Author

LinkIsGrim commented Oct 23, 2023

Removed uniform scaling altogether as that was going to cause more issues than it would solve.
Armor scaling for vests is now log10(armor/(passThrough ^ 0.6) * 10

Math below, 3.15.2 -> X indicates armor/damage prior to 3.16.0

For a vanilla Carrier Rig + B_Soldier_F uniform, HitChest:
22/0.2 (a/p) -> 17.20 (scaled vest) + 1 (hitpoint armor) * 2 (overall armor) = 19.20, 3.15.2 -> 22

RHS vests:
28/0.1 (a/p) -> 20.05 (scaled vest) + same as above, = 22.05, 3.15.2 -> 30

Vanilla/RHS 5.56 (hit = 9, though out of a 11.5in rifle it'd hit for 7.728, so using this value):
Carrier Rig: damage = 0.4025 (medium velocity wound) 3.15.2 ->0.351 (small velocity wound)
RHS vest: damage = 0.350 (small velocity wound/large bruise) 3.15.2 -> 0.2576 (medium/large bruise)

Assuming full damage:
RHS: 0.408, 3.15.2 -> 0.3 (medium velocity wound)
Carrier Rig: 0.469, 3.15.2 -> 0.4 (medium velocity wound)

IMO there's only so much we can do before players have to just use something that hits harder, lest we make armor useless.

@LinkIsGrim LinkIsGrim changed the title Medical Engine - Increase passthrough effect for vests Medical Engine - Disable uniform passthrough scaling, increase passthrough effect on vests Oct 24, 2023
@LinkIsGrim LinkIsGrim merged commit be6582e into acemod:master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants