Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical GUI - Change minimal value of damage threshold #9538

Merged
merged 4 commits into from Oct 19, 2023

Conversation

MiszczuZPolski
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Oct 19, 2023
@jonpas jonpas added this to the 3.16.1 milestone Oct 19, 2023
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Oct 19, 2023

I'd prefer handling this at the source but who the hell ie crazy enough to use damage threshold at 0 anyway?

@PabstMirror
Copy link
Contributor

changing
https://github.com/acemod/ACE3/blob/master/addons/medical_gui/functions/fnc_updateBodyImage.sqf#L94
to add max 0.01 might be safer for compatiblity

@MiszczuZPolski
Copy link
Contributor Author

I'd prefer handling this at the source but who the hell ie crazy enough to use damage threshold at 0 anyway?

I discovered this bug when i was helping one guy with medical options, i think people use it as easy way to ensure every hit is lethal to AI.

@MiszczuZPolski
Copy link
Contributor Author

@PabstMirror is it alright now? 🤔

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror changed the title Medical Engine - Change minimal value of damage threshold Medical GUI - Change minimal value of damage threshold Oct 19, 2023
@LinkIsGrim LinkIsGrim merged commit 2fbc40b into acemod:master Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants