Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Add param to skip refresh animation #9546

Merged
merged 7 commits into from Oct 26, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Oct 20, 2023

When merged this pull request will:

  • Title.
  • Skip right panel refresh animation when switching items in the left panel.

IMO FUNC(refresh) should skip by default.

Since it defaults to off, no refresh animation will be played upon modifying virtual items array (which was my intention).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim marked this pull request as draft October 20, 2023 02:38
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Oct 24, 2023
@LinkIsGrim LinkIsGrim marked this pull request as ready for review October 24, 2023 04:46
@LinkIsGrim
Copy link
Contributor Author

Updated action docs and added special case handling for 3DEN.

@PabstMirror PabstMirror added this to the 3.16.2 milestone Oct 26, 2023
@PabstMirror PabstMirror merged commit bbcec5c into acemod:master Oct 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants