Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Engine - Fix script error for 0 overall hitpoint armor #9633

Merged
merged 2 commits into from Nov 10, 2023
Merged

Medical Engine - Fix script error for 0 overall hitpoint armor #9633

merged 2 commits into from Nov 10, 2023

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Nov 8, 2023

When merged this pull request will:

  • Title.

I haven't tested it yet, I will test it in about 3-4 hours.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Nov 8, 2023
@johnb432 johnb432 added this to the 3.16.2 milestone Nov 8, 2023
@johnb432 johnb432 linked an issue Nov 8, 2023 that may be closed by this pull request
Error Zero divisor when unit shot #9632
Closed
LinkIsGrim
LinkIsGrim requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't affect first hit after a loadout change otherwise.

addons/medical_engine/functions/fnc_getHitpointArmor.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim changed the title Medical engine - Fix for #9632 Medical Engine - Fix for #9632 Nov 8, 2023
@johnb432 @LinkIsGrim
Update addons/medical_engine/functions/fnc_getHitpointArmor.sqf
739e7b7 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim LinkIsGrim changed the title Medical Engine - Fix for #9632 Medical Engine - Fix script error for 0 overall hitpoint armor Nov 10, 2023
@LinkIsGrim
Copy link
Contributor

To be clear, no one should be making hitpoints with armor 0. This is purely exception handling.

@LinkIsGrim LinkIsGrim merged commit 0ae0024 into master Nov 10, 2023
5 checks passed
@jonpas jonpas deleted the 9632-error-zero-divisor-when-unit-shot branch November 10, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.

Error Zero divisor when unit shot
2 participants
@johnb432 @LinkIsGrim