Medical - Prevent running FUNC(deserializeState) in scheduled environment

[LinkIsGrim]

When merged this pull request will:

• Title.
• Close undefined variable error in fnc_deserializeState.sqf at line 54. Found a fix. Might need to be added to repository #9636

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

// Handle wound hashmaps deserialized as CBA_namespaces
if (!isNil "_value" && {_value isEqualType locationNull}) then {
    private _keys = allVariables _value;
    private _values = _keys apply {_value getVariable _x};
    _value = _keys createHashMapFromArray _values;
};

// Treat null as nil
if (isNil "_value" || {_value isEqualTo objNull}) then {
    _value = _default;
};

The suggested code above still throws an error in scheduled, so your fix is needed.

I added the !isNil "_value" and isNil "_value" checks, so that it's explicitly written. I also changed typeName _value == "LOCATION" to _value isEqualType locationNull.

[LinkIsGrim]

You're gonna have to ELI5 above, besides the typeName change

[johnb432]

You're gonna have to ELI5 above, besides the typeName change

ACE3/addons/medical/functions/fnc_deserializeState.sqf

Lines 59 to 69 in 65be883

	// Handle wound hashmaps deserialized as CBA_namespaces
	if (typeName _value == "LOCATION") then {
	private _keys = allVariables _value;
	private _values = _keys apply {_value getVariable _x};
	_value = _keys createHashMapFromArray _values;
	};
	// Treat null as nil
	if (_value isEqualTo objNull) then {
	_value = _default;
	};

Replace these lines with the ones I put above.

Essentially, we now are doing isNil checks where there were none previously. _value isEqualTo objNull, with _value being nil, would not behave as expected.

[PabstMirror]

{
    private _value = _state getVariable _x;
    if (typeName _value == "LOCATION") then {
 
} forEach [
    [VAR_BLOOD_VOL, DEFAULT_BLOOD_VOLUME],

I'm pretty sure _value should always be defined
_x is an array not a string