Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Search fixes #9668

Merged
merged 1 commit into from Dec 3, 2023
Merged

Arsenal - Search fixes #9668

merged 1 commit into from Dec 3, 2023

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Dec 2, 2023

When merged this pull request will:

  • If two or more items had the same display name and you selected e.g. the second one, it would select the top most one when searching. E.g. having the M1 Garand selected from the CDLC SPE, but when updating the search bar, it would select the M1 Garand from the Iron Front mod.
    The fix for this is to find the class name instead of the display name.
  • When searching in the listnbox panels (i.e. container content), it would deselect the currently selected item when removing characters from the search. E.g. seaching for rope and having the item Rope 15.2 meters selected, then updating the search to rop would deselect the item Rope 15.2 meters.
    Now it only deselects the item if it isn't part of the search results.
  • If an item wasn't found or just generally by default, it would select the first item in the container content.
    Now it doesn't select anything by default.

The last change is a matter of opinion, can easily be reverted to selecting the first item.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Dec 2, 2023
@rautamiekka
Copy link
Contributor

The last change is a matter of opinion, can easily be reverted to selecting the first item.

Hell no, it ain't a matter of opinion but UX, an extremely annoying one at that, so I'm glad it's finally getting fixed.

@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Dec 2, 2023
@PabstMirror PabstMirror merged commit acca95d into master Dec 3, 2023
5 checks passed
@PabstMirror PabstMirror deleted the arsenal-search-fix branch December 3, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants