Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Make FUNC(isModLoaded) case-insensitive #9704

Merged
merged 5 commits into from Jan 1, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • We could make it so that ace_common_fnc_isModLoaded is not case sensitive, but that means adding a toLowerANSI.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

I think we should make the func non-case sensitive and easy to use (it's Public: Yes)
I'm really shocked all these things were broken and not noticed

are non-ansi even allowed in config names?

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Dec 31, 2023
@LinkIsGrim
Copy link
Contributor

I'm not sure why it wasn't made case-insensitive when the cache was introduced (performance concerns on using a toLower)? The function works regardless, a cache miss due to casing just means the config lookup is done again. But yeah it should be changed IMO

AFAIK non-ANSI isn't allowed in config, no.

@LinkIsGrim
Copy link
Contributor

Mod name (I assume this was to be used with modParams) never actually worked, updated header to match.

@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Dec 31, 2023
@LinkIsGrim LinkIsGrim changed the title General - ace_common_fnc_isModLoaded is case sensitive Common - Make FUNC(isModLoaded) case-insensitive Dec 31, 2023
johnb432 and others added 2 commits December 31, 2023 17:35
@johnb432 johnb432 merged commit 8ca5263 into master Jan 1, 2024
5 checks passed
@johnb432 johnb432 deleted the modcache-case-sensitvity branch January 1, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants