Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add Painkillers #9720

Merged
merged 6 commits into from Feb 5, 2024
Merged

Medical - Add Painkillers #9720

merged 6 commits into from Feb 5, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Add painkillers. Finally.

Implementation based on https://github.com/Theseus-Aegis/Mods/tree/master/addons/medical, with increased timeTillMaxEffect.

I've always wanted to see painkillers added as a magazine, though (I feel like that's interesting as API and example), but this is simpler and shouldn't break things for communities with their own implementations too much.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Jan 7, 2024
@LinkIsGrim
Copy link
Contributor Author

It works (as it should), but could probably use a better model for litter/item, as they're currently shared and are not the best:
20240107195347_1

Something based off the inventory icon (orange-ish tube) would be ideal.

@Drofseh
Copy link
Contributor

Drofseh commented Jan 7, 2024

What painkiller are we trying to simulate here?
A previous unit I was in implemented painkillers in their house mod, and these are the values that were used to simulate something like ibuprofen or acetaminophen/paracetamol

class PainKillers {
    painReduce = 0.1;
    timeInSystem = 1200;
    timeTillMaxEffect = 60;
    maxDose = 25;
    incompatibleMedication[] = {};
    viscosityChange = 5;
};

we were actually considering reducing painReduce below 0.1 as we felt it was a bit too strong for that type of analgesic

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@jonpas
Copy link
Member

jonpas commented Jan 7, 2024

@Drofseh Our values just come from what we wanted in gameplay. Something that reduces pain for a short period of time, not a longer-term solution.

@jonpas jonpas changed the title Medical - Painkillers Medical - Add Painkillers Jan 7, 2024
@LinkIsGrim
Copy link
Contributor Author

Missing CfgPatches entries still

@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Jan 8, 2024
@johnb432
Copy link
Contributor

Missing CfgPatches entries still

Done.

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syringe sound is played when painkillers are administered.

Either we remove the sound entirely or replace it with something else.

@Zman6258
Copy link
Contributor

Either we remove the sound entirely or replace it with something else.

pills.zip

Recorded and edited myself so there's no chance of any rights issues, if y'all wanna use it. Five-second audio file in .ogg format of a bottle of pills opening, getting shaken a little to represent actually taking one, then closing again.

@LinkIsGrim LinkIsGrim modified the milestones: 3.17.0, 3.16.4 Feb 4, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim LinkIsGrim merged commit 4bb9d6c into master Feb 5, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the medical-painKillers branch February 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants