Night Vision - Use slotItemChanged event

[LinkIsGrim]

When merged this pull request will:

• Title.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[PabstMirror]

What is the advantage over playerEH?
It's a global EH so it seems like it might run a bit more often

[LinkIsGrim]

Running on same frame as the slot item is changed

And I don't like running anything off playerEH if we can avoid it but that's just me being needlessly opinionated

[johnb432]

Can't we add it just for ACE_player via a unit switched EH? It would reduce the amount of calls.

[johnb432]

@LinkIsGrim I changed it so it runs on ACE_player only. I'm not sure about the manually calling of [] call FUNC(refreshGoggleType); and whether CBA_fnc_addPlayerEventHandler should run on existing units (e.g. firing at mission start).

[PabstMirror]

Running on same frame as the slot item is changed

seems to be a frame behind when dragging from inventory,
but first in the same frame when using scripted cmds?

["loadout", {
    diag_log text format ["TEST %1 loadout EH [%2] %3", diag_frameNo, hmd player];
 }, true] call CBA_fnc_addPlayerEventHandler;

player addEventHandler ["SlotItemChanged", {
    diag_log text format ["TEST %1 SlotItemChanged EH [%2] %3", diag_frameNo, hmd player, _this];
 }];

// drag to ground
TEST 47708 loadout EH [] 
TEST 47709 SlotItemChanged EH [] [B Alpha 1-1:1 (Pabst Mirror),"NVGoggles",616,false]

// drag back on
TEST 48244 loadout EH [NVGoggles] 
TEST 48245 SlotItemChanged EH [NVGoggles] [B Alpha 1-1:1 (Pabst Mirror),"NVGoggles",616,true]

"scripted add" // diag_log "scripted add"; player linkItem "ACE_NVG_Gen4";
TEST 48967 SlotItemChanged EH [ACE_NVG_Gen4] [B Alpha 1-1:1 (Pabst Mirror),"NVGoggles",616,false]
TEST 48967 SlotItemChanged EH [ACE_NVG_Gen4] [B Alpha 1-1:1 (Pabst Mirror),"ACE_NVG_Gen4",616,true]
TEST 48967 loadout EH [ACE_NVG_Gen4] 

[PabstMirror]

getting very strange results in 3den when using missions with arsenal set

• place unit, change NVG to something custom (like ACE_NVGoggles_WP)

onSlotItemChanged: _item=ACE_NVGoggles_WP, _slot=616, _assign=true, hmd player=ACE_NVGoggles_WP
onSlotItemChanged: _item=NVGoggles, _slot=616, _assign=true, hmd player=ACE_NVGoggles_WP
onSlotItemChanged: _item=NVGoggles, _slot=616, _assign=false, hmd player=ACE_NVGoggles_WP

Slot EH for the new item happens first
Then it adds and removes the old item?
end result is broken because ace_nightvision_playerHMD = "" because the the unassinemnt was the last thing to happen

[johnb432]

getting very strange results in 3den when using missions with arsenal set

* place unit, change NVG to something custom (like `ACE_NVGoggles_WP`)

onSlotItemChanged: _item=ACE_NVGoggles_WP, _slot=616, _assign=true, hmd player=ACE_NVGoggles_WP
onSlotItemChanged: _item=NVGoggles, _slot=616, _assign=true, hmd player=ACE_NVGoggles_WP
onSlotItemChanged: _item=NVGoggles, _slot=616, _assign=false, hmd player=ACE_NVGoggles_WP

Slot EH for the new item happens first Then it adds and removes the old item? end result is broken because ace_nightvision_playerHMD = "" because the the unassinemnt was the last thing to happen

Is this with the latest commit or the older code (or both)?
How bad is it, if ace_nightvision_playerHMD is broken in the editor?

[johnb432]

@PabstMirror Can you make a bug report, if you haven't already?

I guess we'll need to set this PR on ice for now.

[johnb432]

"SlotItemChanged" doesn't detect changes properly when executing player setUnitLoadout getUnitLoadout player.
Unfortunately, it's unusable atm.

I've made a bug report: https://feedback.bistudio.com/T180338.

[johnb432]

Fix has been pushed to the profiling branch, but it means we'll have to wait until 2.18 to get this.

[johnb432]

LGTM, once 2.18 is out. Works on the current profiling branch.