make sure the session is active #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the MRIProcessingUtility.pm, there are lines 92 (lookupNextVisitLabel) and 513 (in the update_mri_acquisition_dates), shouldn;t these also be set to search/update session with Active='Y'? |
|
@MounaSafiHarab Good catch, I've updated those as well. |
|
tested it and it is all good. My concern though is on the Loris side, why is the NDB_Menu_Filter_imaging_browser.class.inc not querying on Active='Y'? as it stands, the inactive session gets displayed but when we click on it, it says 'Failed to retrieve data for timepoint' (I think we should add: AND s.Active = 'Y' on line 105). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session can be inactive, but should not be chosen for insertion