Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Current stage when creating the visit for the bids_import.py pipeline #644

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Jul 15, 2021

Current_stage is not set when creating a visit via the bids_import.py pipeline which causes the frontend to crash when trying to load the candidate page in access profile.

PHP Fatal error:  Uncaught TypeError: Return value of Utility::getStageUsingCandID() must be of the type string, null returned in /var/www
> /loris/php/libraries/Utility.class.inc:632\nStack trace:\n#0 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(177): Utility::getStageUsingCandID('207019')\n#1 /var/www/loris/php/libraries/NDB_Page.class.inc(
> 707): LORIS\\instrument_list\\Instrument_List->setup()\n#2 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(234): NDB_Page->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#3 /var/www/loris/src/Middleware/PageD
> ecorationMiddleware.php(56): LORIS\\Middleware\\UserPageDecorationMiddleware->process(Object(Laminas\\Diactoros\\ServerRequest), Object(LORIS\\instrument_list\\Instrument_List))\n#4 /var/www/loris/php/libraries/NDB_Page.class.i
> nc(692): LORIS\\Middleware\\PageDecorationMiddleware->process(Object(Laminas\\Diactoros\\ServerRequest), Object(LORIS\\instrument_list\\Instrument_List))\n#5 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(
> 137): NDB_Page->pro in /var/www/loris/php/libraries/Utility.class.inc on line 632, referer: https://ipmsa-loris.bic.mni.mcgill.ca/candidate_profile/207019/

The changes here add a "Not Started" value for the Current_stage of the visit when a new visit is created in the session table.

@cmadjar cmadjar added BIDS import pipeline Issues regarding the BIDS import pipeline Bug Python imaging pipeline and removed Python imaging pipeline labels Jul 15, 2021
@cmadjar cmadjar merged commit a3d9e3a into aces:main Jul 21, 2021
@cmadjar
Copy link
Collaborator Author

cmadjar commented Jul 21, 2021

Tested by Alfredo.

@cmadjar cmadjar added this to the 24.0.0 milestone Sep 10, 2021
@cmadjar cmadjar deleted the add_current_stage_when_creating_session branch September 24, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIDS import pipeline Issues regarding the BIDS import pipeline Bug Copied in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant